Hyprland Configuration Rework #63

Merged

Ghost merged 0 commits from refs/pull/63/head into master

2025-10-06 11:51:47 +10:00

Ghost commented

2025-10-06 11:47:23 +10:00

(Migrated from codeberg.org)

Named workspaces
- For applications like vesktop, email, gaming etc.
Workspace tags (with rules applied to tags)
Workspace / Monitor Binding rework
Slightly changed colourscheme and shadows

$mod, 1..3 will navigate to monitors instead of workspaces,
Workspaces can be configured / set using workspace submap.

$mod, W enables submap and 1..1(0) will change the numbered workspace

Summary by CodeRabbit

New Features
- Added dedicated workspace module with named workspaces (gaming, music, email, chat), submap navigation, and keybindings.
- Per-workspace behaviors: monitor bindings and auto-launch commands for select workspaces.
Refactor
- Migrated window rules to a tag-based model (gaming/video) and consolidated app rules.
- Replaced auto-generated workspace bindings with an explicit workspaces submap.
Style
- Updated window border color and shadow appearance.
Chores
- Removed obsolete monitor descriptors from the workspace configuration.

- Named workspaces - For applications like vesktop, email, gaming etc. - Workspace tags (with rules applied to tags) - Workspace / Monitor Binding rework - Slightly changed colourscheme and shadows $mod, 1..3 will navigate to monitors instead of workspaces, Workspaces can be configured / set using workspace submap. $mod, W enables submap and 1..1(0) will change the numbered workspace  ## Summary by CodeRabbit - New Features - Added dedicated workspace module with named workspaces (gaming, music, email, chat), submap navigation, and keybindings. - Per-workspace behaviors: monitor bindings and auto-launch commands for select workspaces. - Refactor - Migrated window rules to a tag-based model (gaming/video) and consolidated app rules. - Replaced auto-generated workspace bindings with an explicit workspaces submap. - Style - Updated window border color and shadow appearance. - Chores - Removed obsolete monitor descriptors from the workspace configuration.

Ghost commented

2025-10-06 11:47:32 +10:00

(Migrated from codeberg.org)

Walkthrough

Introduces a new Hyprland workspaces module with named workspaces and keybindings, shifts window rules to tag-based logic with an added apprules file, removes autogenerated workspace binds from binds.nix, wires the new module via imports, tweaks visual settings, and removes two monitor descriptors from a host config.

Changes

Cohort / File(s)	Summary
Hyprland workspaces module `modules/homeManagerModules/hyprland/workspaces.nix`	New module defining named workspaces (gaming, music, email, chat), dynamic 1–10 workspace labels, submap for workspace actions, keybindings, per-workspace settings, and on-created-empty commands.
Bindings refactor `modules/homeManagerModules/hyprland/binds.nix`	Removed dynamic workspace binding generator and its injection into bindm; retains only fixed binds.
Rules rework + app rules `modules/homeManagerModules/hyprland/rules.nix`, `modules/homeManagerModules/hyprland/apprules.nix`	Added apprules import and static rule set; migrated from workspace-based to tag-based rules (gaming/video) and adjusted named workspace assignments (email/chat/music).
Module wiring `modules/homeManagerModules/hyprland/default.nix`	Added `./workspaces.nix` to imports when Hyprland is enabled.
Visual settings `modules/homeManagerModules/hyprland/settings.nix`	Updated border color and shadow color/offset; no logic changes.
Host monitor descriptors cleanup `hosts/striking_distance/default.nix`	Removed two monitor descriptor entries; no other changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Hyprland
  participant Workspaces as Workspaces Module
  participant Rules as Rules & AppRules
  participant App as Applications

  User->>Hyprland: Keybind (workspace/move/focus)
  Hyprland->>Workspaces: Resolve submap action
  Workspaces-->>Hyprland: Target workspace (named or numeric)
  Hyprland->>Rules: Apply window rules/tags
  Rules-->>Hyprland: Tag set (e.g., gaming, video, chat)
  Hyprland->>App: Assign workspace, set states (fullscreen/float)
  note over Hyprland,Rules: New: tag-based matching replaces workspace-coupled rules

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Kruziikrel13/NixOS#58 — Implements named workspaces, tag-based application rules, and reworked binds/workspaces modules aligning with the issue’s objectives.

Poem

I mapped my hops to numbered skies,
Then named the clouds before my eyes.
Tags on breezes, windows glide,
Gaming burrows, chats beside.
Shadows trimmed, borders bright—
A tidy warren for the night. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly captures the major rework to Hyprland configuration, reflecting updates to workspace and monitor binding behavior as outlined in the PR objectives. It is concise, clear, and directly relates to the primary change. It avoids unnecessary detail while conveying the scope of the update.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch hyprland_rework

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

## Walkthrough Introduces a new Hyprland workspaces module with named workspaces and keybindings, shifts window rules to tag-based logic with an added apprules file, removes autogenerated workspace binds from binds.nix, wires the new module via imports, tweaks visual settings, and removes two monitor descriptors from a host config. ## Changes | Cohort / File(s) | Summary | | --- | --- | | **Hyprland workspaces module** `modules/homeManagerModules/hyprland/workspaces.nix` | New module defining named workspaces (gaming, music, email, chat), dynamic 1–10 workspace labels, submap for workspace actions, keybindings, per-workspace settings, and on-created-empty commands. | | **Bindings refactor** `modules/homeManagerModules/hyprland/binds.nix` | Removed dynamic workspace binding generator and its injection into bindm; retains only fixed binds. | | **Rules rework + app rules** `modules/homeManagerModules/hyprland/rules.nix`, `modules/homeManagerModules/hyprland/apprules.nix` | Added apprules import and static rule set; migrated from workspace-based to tag-based rules (gaming/video) and adjusted named workspace assignments (email/chat/music). | | **Module wiring** `modules/homeManagerModules/hyprland/default.nix` | Added `./workspaces.nix` to imports when Hyprland is enabled. | | **Visual settings** `modules/homeManagerModules/hyprland/settings.nix` | Updated border color and shadow color/offset; no logic changes. | | **Host monitor descriptors cleanup** `hosts/striking_distance/default.nix` | Removed two monitor descriptor entries; no other changes. | ## Sequence Diagram(s) ```mermaid sequenceDiagram autonumber actor User participant Hyprland participant Workspaces as Workspaces Module participant Rules as Rules & AppRules participant App as Applications User->>Hyprland: Keybind (workspace/move/focus) Hyprland->>Workspaces: Resolve submap action Workspaces-->>Hyprland: Target workspace (named or numeric) Hyprland->>Rules: Apply window rules/tags Rules-->>Hyprland: Tag set (e.g., gaming, video, chat) Hyprland->>App: Assign workspace, set states (fullscreen/float) note over Hyprland,Rules: New: tag-based matching replaces workspace-coupled rules ``` ## Estimated code review effort 🎯 3 (Moderate) | ⏱️ ~25 minutes ## Possibly related issues - Kruziikrel13/NixOS#58 — Implements named workspaces, tag-based application rules, and reworked binds/workspaces modules aligning with the issue’s objectives. ## Poem > I mapped my hops to numbered skies, > Then named the clouds before my eyes. > Tags on breezes, windows glide, > Gaming burrows, chats beside. > Shadows trimmed, borders bright— > A tidy warren for the night. 🥕✨   ## Pre-merge checks and finishing touches <details> <summary>✅ Passed checks (3 passed)</summary> | Check name | Status | Explanation | | :----------------: | :------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title Check | ✅ Passed | The title succinctly captures the major rework to Hyprland configuration, reflecting updates to workspace and monitor binding behavior as outlined in the PR objectives. It is concise, clear, and directly relates to the primary change. It avoids unnecessary detail while conveying the scope of the update. | | Docstring Coverage | ✅ Passed | No functions found in the changes. Docstring coverage check skipped. | </details>   <details> <summary>✨ Finishing touches</summary> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Post copyable unit tests in a comment - [ ]  Commit unit tests in branch `hyprland_rework` </details> </details>   --- Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> Comment `@coderabbitai help` to get the list of available commands and usage tips.