remove flake compat and parts dependencies #8

Merged

Ghost merged 1 commit from refs/pull/8/head into 2025-Flake

2025-05-20 12:27:06 +10:00

Ghost commented

2025-05-20 12:26:22 +10:00

(Migrated from codeberg.org)

Can achieve same functionality with just a few functions

Summary by CodeRabbit

Refactor
- Simplified and streamlined Nix flake configuration, removing complex abstractions and unused dependencies.
- Generalized user configuration to support dynamic usernames instead of hardcoded values.
- Flattened and clarified package and system configuration structures for easier customization.
- Updated references to packages and overlays for improved maintainability.
- Deleted obsolete overlay configuration file.

Can achieve same functionality with just a few functions  ## Summary by CodeRabbit - **Refactor** - Simplified and streamlined Nix flake configuration, removing complex abstractions and unused dependencies. - Generalized user configuration to support dynamic usernames instead of hardcoded values. - Flattened and clarified package and system configuration structures for easier customization. - Updated references to packages and overlays for improved maintainability. - Deleted obsolete overlay configuration file.

Ghost commented

2025-05-20 12:26:29 +10:00

(Migrated from codeberg.org)

Walkthrough

The project’s Nix flake and module structure was refactored to remove flake-parts, simplify outputs, and generalize user configuration. Inputs and overlays related to removed dependencies were deleted. User and home-manager modules now accept a username parameter, enabling dynamic user configuration. Package and overlay definitions were flattened and streamlined.

Changes

File(s)	Change Summary
`flake.nix`	Refactored to remove `flake-parts`, simplify outputs, and clean up unused inputs. Outputs now directly define `nixosConfigurations` and `packages` for "x86_64-linux". DevShell, formatter, and related inputs were removed.
`home/default.nix`, `hosts/striking_distance/home/default.nix`, `system/core/users.nix`	Changed user attribute keys from hardcoded `"kruziikrel13"` to dynamic `${username}`; added `username` as a parameter to enable flexible user configuration.
`home/programs/hyprland/default.nix`, `system/programs/hyprland/default.nix`	Added `self` parameter and updated references to `bibata-hyprcursor` to use `self.packages` instead of `inputs.self.packages`.
`hosts/default.nix`	Refactored to use a top-level `let`, introduced `makeSpecialArgs` function for parameterized user arguments, and explicitly set system architecture.
`pkgs/default.nix`	Simplified package export by removing system-specific nesting and exporting a direct function returning the `bibata-hyprcursor` package.
`system/overlays.nix`	Deleted overlay file that previously pinned and customized the `limo` package and imported a Neovim overlay.

Sequence Diagram(s)

sequenceDiagram
    participant Flake as flake.nix
    participant Hosts as hosts/default.nix
    participant Home as home/default.nix
    participant System as system/core/users.nix
    participant Pkgs as pkgs/default.nix

    Flake->>Hosts: import ./hosts { self, nixpkgs, inputs }
    Hosts->>System: makeSpecialArgs("username") → { username, ... }
    Hosts->>Home: import home module with { username }
    Flake->>Pkgs: import ./pkgs nixpkgs.legacyPackages.${system}
    Home->>Pkgs: Reference bibata-hyprcursor via self.packages

Poem

🐇
Refactored flake, the code’s now neat,
No more hardcoded user seat!
With overlays gone and outputs clear,
Dynamic users now appear.
Bibata cursors hop with pride,
In streamlined Nix, we rabbits reside!
🌱✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 525a3979e3 and 48fe0c4f2a.

⛔ Files ignored due to path filters (1)

flake.lock is excluded by !**/*.lock

📒 Files selected for processing (9)

flake.nix (1 hunks)
home/default.nix (2 hunks)
home/programs/hyprland/default.nix (1 hunks)
hosts/default.nix (1 hunks)
hosts/striking_distance/home/default.nix (1 hunks)
pkgs/default.nix (1 hunks)
system/core/users.nix (1 hunks)
system/overlays.nix (0 hunks)
system/programs/hyprland/default.nix (1 hunks)

💤 Files with no reviewable changes (1)

system/overlays.nix

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

## Walkthrough The project’s Nix flake and module structure was refactored to remove `flake-parts`, simplify outputs, and generalize user configuration. Inputs and overlays related to removed dependencies were deleted. User and home-manager modules now accept a `username` parameter, enabling dynamic user configuration. Package and overlay definitions were flattened and streamlined. ## Changes | File(s) | Change Summary | |------------------------------------------------------------------------------------------|---------------| | `flake.nix` | Refactored to remove `flake-parts`, simplify outputs, and clean up unused inputs. Outputs now directly define `nixosConfigurations` and `packages` for "x86_64-linux". DevShell, formatter, and related inputs were removed. | | `home/default.nix`, `hosts/striking_distance/home/default.nix`, `system/core/users.nix` | Changed user attribute keys from hardcoded `"kruziikrel13"` to dynamic `${username}`; added `username` as a parameter to enable flexible user configuration. | | `home/programs/hyprland/default.nix`, `system/programs/hyprland/default.nix` | Added `self` parameter and updated references to `bibata-hyprcursor` to use `self.packages` instead of `inputs.self.packages`. | | `hosts/default.nix` | Refactored to use a top-level `let`, introduced `makeSpecialArgs` function for parameterized user arguments, and explicitly set system architecture. | | `pkgs/default.nix` | Simplified package export by removing system-specific nesting and exporting a direct function returning the `bibata-hyprcursor` package. | | `system/overlays.nix` | Deleted overlay file that previously pinned and customized the `limo` package and imported a Neovim overlay. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant Flake as flake.nix participant Hosts as hosts/default.nix participant Home as home/default.nix participant System as system/core/users.nix participant Pkgs as pkgs/default.nix Flake->>Hosts: import ./hosts { self, nixpkgs, inputs } Hosts->>System: makeSpecialArgs("username") → { username, ... } Hosts->>Home: import home module with { username } Flake->>Pkgs: import ./pkgs nixpkgs.legacyPackages.${system} Home->>Pkgs: Reference bibata-hyprcursor via self.packages ``` ## Poem > 🐇 > Refactored flake, the code’s now neat, > No more hardcoded user seat! > With overlays gone and outputs clear, > Dynamic users now appear. > Bibata cursors hop with pride, > In streamlined Nix, we rabbits reside! > 🌱✨   > [!NOTE] > <details> > <summary>⚡️ AI Code Reviews for VS Code, Cursor, Windsurf</summary> > > CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. > Learn more [here](http://coderabbit.ai/ide). > > </details> --- > [!NOTE] > <details> > <summary>⚡️ Faster reviews with caching</summary> > > CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure `Review - Disable Cache` at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the `Data Retention` setting under your Organization Settings. > Enjoy the performance boost—your workflow just got faster. > > </details>  --- <details> <summary>📜 Recent review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Free** **Cache: Disabled due to data retention organization setting** **Knowledge Base: Disabled due to data retention organization setting** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 525a3979e3ee488f40de50c0f150698d1f91bf74 and 48fe0c4f2a5e122c758cb9fdb3b2f0367e82fb08. </details> <details> <summary>⛔ Files ignored due to path filters (1)</summary> * `flake.lock` is excluded by `!**/*.lock` </details> <details> <summary>📒 Files selected for processing (9)</summary> * `flake.nix` (1 hunks) * `home/default.nix` (2 hunks) * `home/programs/hyprland/default.nix` (1 hunks) * `hosts/default.nix` (1 hunks) * `hosts/striking_distance/home/default.nix` (1 hunks) * `pkgs/default.nix` (1 hunks) * `system/core/users.nix` (1 hunks) * `system/overlays.nix` (0 hunks) * `system/programs/hyprland/default.nix` (1 hunks) </details> <details> <summary>💤 Files with no reviewable changes (1)</summary> * system/overlays.nix </details> </details>     --- > [!NOTE] > <details> > <summary>🎁 Summarized by CodeRabbit Free</summary> > > Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>. > > </details> <details> <summary>🪧 Tips</summary> ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=Kruziikrel13/NixOS&utm_content=8): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Explain this complex logic.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai explain this code block.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and explain its main purpose.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` ### Support Need help? Join our [Discord community](https://discord.gg/coderabbit) for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </details>