Add Personal Module #64

Merged

Ghost merged 3 commits from refs/pull/64/head into master

2025-10-06 13:38:24 +10:00

Ghost commented

2025-10-06 13:38:08 +10:00

(Migrated from codeberg.org)

With hyprland config settings grouped within

Summary by CodeRabbit

New Features
- Introduced a personal module that unifies system and Home Manager configuration, including Hyprland setup (with UWSM), Wayland environment variables, and per-user integration via a username setting.
Refactor
- Consolidated Hyprland configuration into dedicated modules; hosts and program configs now rely on the personal module.
- System configuration now accepts a username parameter and imports the personal module by default.
Chores
- Removed legacy Hyprland modules and backup files.
Documentation
- Added README detailing the personal module’s usage and scope.

- With hyprland config settings grouped within  ## Summary by CodeRabbit - New Features - Introduced a personal module that unifies system and Home Manager configuration, including Hyprland setup (with UWSM), Wayland environment variables, and per-user integration via a username setting. - Refactor - Consolidated Hyprland configuration into dedicated modules; hosts and program configs now rely on the personal module. - System configuration now accepts a username parameter and imports the personal module by default. - Chores - Removed legacy Hyprland modules and backup files. - Documentation - Added README detailing the personal module’s usage and scope.

Ghost commented

2025-10-06 13:38:35 +10:00

(Migrated from codeberg.org)

Caution

Review failed

The pull request is closed.

Walkthrough

Hyprland-specific NixOS and Home Manager modules were removed and replaced with a new consolidated personalModule that encapsulates Hyprland system and user configuration. Hosts and home imports dropped explicit Hyprland references. System wiring now passes a username into personalModule to drive Home Manager configuration, and Hyprland-related system settings were moved into dedicated modules.

Changes

Cohort / File(s)	Summary of changes
Hosts import cleanup `hosts/aridhol/default.nix`, `hosts/striking_distance/default.nix`	Removed `self.nixosModules.hyprland` from host imports; no other functional edits.
Home programs import tweak `home/programs/default.nix`	Simplified imports to rely solely on `paths.scanPaths ./.`; removed `self.homeManagerModules.hyprland`.
Module index updates `modules/default.nix`	Removed `nixosModules.hyprland` and `homeManagerModules.hyprland`; added `nixosModules.personalModule`.
Remove Hyprland modules (NixOS + HM) `modules/nixosModules/hyprland.nix`, `modules/homeManagerModules/hyprland/*`	Deleted NixOS Hyprland module and Hyprland Home Manager module (including `ags.nix.bak` and `default.nix`).
Introduce personal module (docs + core) `modules/personalModule/README.md`, `modules/personalModule/default.nix`	Added a new personalModule with `options.personalModule.username`; imports internal Hyprland config. Added documentation.
Personal Hyprland config (system + HM) `modules/personalModule/hyprlandConfig/default.nix`, `modules/personalModule/hyprlandConfig/home/default.nix`	Added Hyprland configuration module: defines options (`monitors`, `workspaces`), system env/portal/cachix, and wires Home Manager user config (imports local HM Hyprland setup, env vars, files, services).
System wiring `system/default.nix`	Function now takes `self` and `username`; imports `self.nixosModules.personalModule`; sets `personalModule.username = username`.
System programs refactor `system/programs/default.nix`, `system/programs/hyprland.nix`	Moved Hyprland/Qt/env specifics into new `system/programs/hyprland.nix`. Trimmed `system/programs/default.nix` signature and removed Hyprland, Qt, and `hyprqt6engine` wiring there.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Host as Host config
  participant System as system/default.nix
  participant PM as nixosModules.personalModule
  participant HLP as personalModule.hyprlandConfig
  participant HM as Home Manager (user)
  
  Note over Host,System: Hosts no longer import hyprland directly
  Host->>System: Pass { self, username, paths, ... }
  System->>PM: imports personalModule<br/>sets personalModule.username = username
  PM->>HLP: import hyprlandConfig (internal)
  alt programs.hyprland.enable
    HLP->>System: Set system env, portals, cachix
    HLP->>HM: home-manager.users.<username> imports HM Hyprland config
    HM->>HM: Configure Wayland session, files, services
  else disabled
    HLP-->>System: No Hyprland-related config
  end
  Note over PM,HLP: Hyprland logic consolidated under personalModule

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I hop through flakes and nixy land,
Tidying paths with careful hand;
Old Hypr burrows closed, anew I weave,
A personal warren I now conceive.
Username whispered, configs align—
Wayland winds hum, all is fine.
Thump-thump: ship it, right on time! 🐇✨

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch personalModule

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e63caa91f6 and 667987d4b8.

📒 Files selected for processing (14)

home/programs/default.nix (1 hunks)
hosts/aridhol/default.nix (0 hunks)
hosts/striking_distance/default.nix (0 hunks)
modules/default.nix (1 hunks)
modules/homeManagerModules/hyprland/ags.nix.bak (0 hunks)
modules/homeManagerModules/hyprland/default.nix (0 hunks)
modules/nixosModules/hyprland.nix (0 hunks)
modules/personalModule/README.md (1 hunks)
modules/personalModule/default.nix (1 hunks)
modules/personalModule/hyprlandConfig/default.nix (1 hunks)
modules/personalModule/hyprlandConfig/home/default.nix (1 hunks)
system/default.nix (1 hunks)
system/programs/default.nix (0 hunks)
system/programs/hyprland.nix (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

> [!CAUTION] > ## Review failed > > The pull request is closed.   ## Walkthrough Hyprland-specific NixOS and Home Manager modules were removed and replaced with a new consolidated personalModule that encapsulates Hyprland system and user configuration. Hosts and home imports dropped explicit Hyprland references. System wiring now passes a username into personalModule to drive Home Manager configuration, and Hyprland-related system settings were moved into dedicated modules. ## Changes | Cohort / File(s) | Summary of changes | | --- | --- | | **Hosts import cleanup** `hosts/aridhol/default.nix`, `hosts/striking_distance/default.nix` | Removed `self.nixosModules.hyprland` from host imports; no other functional edits. | | **Home programs import tweak** `home/programs/default.nix` | Simplified imports to rely solely on `paths.scanPaths ./.`; removed `self.homeManagerModules.hyprland`. | | **Module index updates** `modules/default.nix` | Removed `nixosModules.hyprland` and `homeManagerModules.hyprland`; added `nixosModules.personalModule`. | | **Remove Hyprland modules (NixOS + HM)** `modules/nixosModules/hyprland.nix`, `modules/homeManagerModules/hyprland/*` | Deleted NixOS Hyprland module and Hyprland Home Manager module (including `ags.nix.bak` and `default.nix`). | | **Introduce personal module (docs + core)** `modules/personalModule/README.md`, `modules/personalModule/default.nix` | Added a new personalModule with `options.personalModule.username`; imports internal Hyprland config. Added documentation. | | **Personal Hyprland config (system + HM)** `modules/personalModule/hyprlandConfig/default.nix`, `modules/personalModule/hyprlandConfig/home/default.nix` | Added Hyprland configuration module: defines options (`monitors`, `workspaces`), system env/portal/cachix, and wires Home Manager user config (imports local HM Hyprland setup, env vars, files, services). | | **System wiring** `system/default.nix` | Function now takes `self` and `username`; imports `self.nixosModules.personalModule`; sets `personalModule.username = username`. | | **System programs refactor** `system/programs/default.nix`, `system/programs/hyprland.nix` | Moved Hyprland/Qt/env specifics into new `system/programs/hyprland.nix`. Trimmed `system/programs/default.nix` signature and removed Hyprland, Qt, and `hyprqt6engine` wiring there. | ## Sequence Diagram(s) ```mermaid sequenceDiagram autonumber participant Host as Host config participant System as system/default.nix participant PM as nixosModules.personalModule participant HLP as personalModule.hyprlandConfig participant HM as Home Manager (user) Note over Host,System: Hosts no longer import hyprland directly Host->>System: Pass { self, username, paths, ... } System->>PM: imports personalModule sets personalModule.username = username PM->>HLP: import hyprlandConfig (internal) alt programs.hyprland.enable HLP->>System: Set system env, portals, cachix HLP->>HM: home-manager.users.<username> imports HM Hyprland config HM->>HM: Configure Wayland session, files, services else disabled HLP-->>System: No Hyprland-related config end Note over PM,HLP: Hyprland logic consolidated under personalModule ``` ## Estimated code review effort 🎯 3 (Moderate) | ⏱️ ~25 minutes ## Poem > I hop through flakes and nixy land, > Tidying paths with careful hand; > Old Hypr burrows closed, anew I weave, > A personal warren I now conceive. > Username whispered, configs align— > Wayland winds hum, all is fine. > Thump-thump: ship it, right on time! 🐇✨   <details> <summary>✨ Finishing touches</summary> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Post copyable unit tests in a comment - [ ]  Commit unit tests in branch `personalModule` </details> </details>  --- <details> <summary>📜 Recent review details</summary> **Configuration used**: CodeRabbit UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between e63caa91f6a4222e789328de0dbb7b0953c22358 and 667987d4b81492927e5060e6ac22411c71c059db. </details> <details> <summary>📒 Files selected for processing (14)</summary> * `home/programs/default.nix` (1 hunks) * `hosts/aridhol/default.nix` (0 hunks) * `hosts/striking_distance/default.nix` (0 hunks) * `modules/default.nix` (1 hunks) * `modules/homeManagerModules/hyprland/ags.nix.bak` (0 hunks) * `modules/homeManagerModules/hyprland/default.nix` (0 hunks) * `modules/nixosModules/hyprland.nix` (0 hunks) * `modules/personalModule/README.md` (1 hunks) * `modules/personalModule/default.nix` (1 hunks) * `modules/personalModule/hyprlandConfig/default.nix` (1 hunks) * `modules/personalModule/hyprlandConfig/home/default.nix` (1 hunks) * `system/default.nix` (1 hunks) * `system/programs/default.nix` (0 hunks) * `system/programs/hyprland.nix` (1 hunks) </details> </details>  --- Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> Comment `@coderabbitai help` to get the list of available commands and usage tips.