rewrite following better practices from several example repositories #11
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "rebuild"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I think this fixes #7 and #4
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores
Removals
Walkthrough
This update restructures a shell UI project by introducing new QML components for bar modules, background, and global styling, while removing or replacing legacy files and centralizing style constants in a new singleton. Several modules, configuration, and appearance files are deleted or replaced. The update also adds Nix development environment files and revises service singletons for audio, network, and Spotify integration.
Changes
.envrc,.gitattributes,.gitignore,.qmlformat.ini,shell.nix.jpg, ignored.qmlls.ini, QML formatting rules, and Nix shell environment with Qt 6 declarative.ShellGlobals.qml,background/Background.qml,bar/Clock.qml,bar/ModuleGroup.qml,bar/Network.qml,bar/OsIcon.qml,bar/Pipewire.qml,bar/Spotify.qml,bar/Window.qml,bar/hyprland/ActiveClient.qml,bar/hyprland/Workspace.qml,bar/hyprland/Workspaces.qml,bar/tray/Tray.qml,bar/tray/TrayItem.qml,components/StyledIcon.qml,components/StyledText.qml,components/StyledWindow.qmlservices/Audio.qml,services/Network.qml,services/SpotifyController.qml,services/SystemInfo.qmlsettings/Appearance.qml,settings/ConfigOptions.qml,widgets/CustomIcon.qml,widgets/StyledShadow.qml,widgets/StyledText.qml,windows/Bar/Bar.qml,windows/Bar/components/ModuleGroup.qml,windows/Bar/components/Separator.qml,windows/Bar/modules/ActiveClient.qml,windows/Bar/modules/Network.qml,windows/Bar/modules/Notifications.qml,windows/Bar/modules/OsIcon.qml,windows/Bar/modules/PowerMenu.qml,windows/Bar/modules/Spotify.qml,windows/Bar/modules/Tray.qml,windows/Bar/modules/Workspaces.qml,windows/MediaControls/MediaControls.qml,windows/OnScreenDisplay/OnScreenDisplayVolume.qml,windows/PowerMenu/PowerMenu.qml,windows/PowerMenu/components/Profile.qml,services/MediaController.qmlshell.qml,.lazy.lua.lazy.lua.Sequence Diagram(s)
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
Poem
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free
📥 Commits
Reviewing files that changed from the base of the PR and between
334a95e170and8caffafb4c.⛔ Files ignored due to path filters (14)
assets/icons/arch-symbolic.svgis excluded by!**/*.svgassets/icons/github-symbolic.svgis excluded by!**/*.svgassets/icons/linux-symbolic.svgis excluded by!**/*.svgassets/icons/nixos-symbolic.svgis excluded by!**/*.svgassets/icons/spotify.svgis excluded by!**/*.svgassets/icons/ubuntu-symbolic.svgis excluded by!**/*.svgassets/wallpapers/icelandbeach.jpgis excluded by!**/*.jpgassets/wallpapers/icelandbeach2.jpgis excluded by!**/*.jpgassets/wallpapers/icelandgeneric.jpgis excluded by!**/*.jpgassets/wallpapers/nepalmountainsnight.jpgis excluded by!**/*.jpgassets/wallpapers/ocean.jpgis excluded by!**/*.jpgassets/wallpapers/scavengersreign1.jpgis excluded by!**/*.jpgassets/wallpapers/scavengersreign2.jpgis excluded by!**/*.jpgassets/wallpapers/sunnymountains.jpgis excluded by!**/*.jpg📒 Files selected for processing (49)
.envrc(1 hunks).gitattributes(1 hunks).gitignore(1 hunks).lazy.lua(0 hunks).qmlformat.ini(1 hunks)ShellGlobals.qml(1 hunks)background/Background.qml(1 hunks)bar/Clock.qml(1 hunks)bar/ModuleGroup.qml(1 hunks)bar/Network.qml(1 hunks)bar/OsIcon.qml(1 hunks)bar/Pipewire.qml(1 hunks)bar/Spotify.qml(1 hunks)bar/Window.qml(1 hunks)bar/hyprland/ActiveClient.qml(1 hunks)bar/hyprland/Workspace.qml(1 hunks)bar/hyprland/Workspaces.qml(1 hunks)bar/tray/Tray.qml(1 hunks)bar/tray/TrayItem.qml(1 hunks)components/StyledIcon.qml(1 hunks)components/StyledText.qml(1 hunks)components/StyledWindow.qml(1 hunks)services/Audio.qml(1 hunks)services/MediaController.qml(0 hunks)services/Network.qml(1 hunks)services/SpotifyController.qml(1 hunks)services/SystemInfo.qml(2 hunks)settings/Appearance.qml(0 hunks)settings/ConfigOptions.qml(0 hunks)shell.nix(1 hunks)shell.qml(1 hunks)widgets/CustomIcon.qml(0 hunks)widgets/StyledShadow.qml(0 hunks)widgets/StyledText.qml(0 hunks)windows/Bar/Bar.qml(0 hunks)windows/Bar/components/ModuleGroup.qml(0 hunks)windows/Bar/components/Separator.qml(0 hunks)windows/Bar/modules/ActiveClient.qml(0 hunks)windows/Bar/modules/Network.qml(0 hunks)windows/Bar/modules/Notifications.qml(0 hunks)windows/Bar/modules/OsIcon.qml(0 hunks)windows/Bar/modules/PowerMenu.qml(0 hunks)windows/Bar/modules/Spotify.qml(0 hunks)windows/Bar/modules/Tray.qml(0 hunks)windows/Bar/modules/Workspaces.qml(0 hunks)windows/MediaControls/MediaControls.qml(0 hunks)windows/OnScreenDisplay/OnScreenDisplayVolume.qml(0 hunks)windows/PowerMenu/PowerMenu.qml(0 hunks)windows/PowerMenu/components/Profile.qml(0 hunks)💤 Files with no reviewable changes (22)
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.Support
Need help? Join our Discord community for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.Other keywords and placeholders
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed.@coderabbitai summaryto generate the high-level summary at a specific location in the PR description.@coderabbitaianywhere in the PR title to generate the title automatically.CodeRabbit Configuration File (
.coderabbit.yaml).coderabbit.yamlfile to the root of your repository.# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.jsonDocumentation and Community